add validator logic for query filters#224
Draft
haileyok wants to merge 3 commits into
Draft
Conversation
haileyok
requested review from
a team,
EXBreder,
ayubun and
vinaysrao1
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is adding a small query filter validator. Eventually we'll expose a small API endpoint that allows the UI to validate SML that is included in the query endpoint (or...configured in a visual builder) and returns errors to the user (without needing to submit a query).
We technically could just write some JS validator that runs in the frontend - and tbh that's probably the better direction eventually - but I don't think we want to end up maintaining a second bit of validation logic right now. There's some other options but they are also all very heavy on the frontend side that I also really do not feel like introducing right now.
Checklist
uv run ruff check .passes (no unused imports or other lint errors)uv tool run fawltydeps --check-unused --pyenv .venvpasses (no unused dependencies)CHANGELOG.mdwith my changes, if applicable